Remove dupe storage item if we get one back, to be compatible with Smoldot + legacy RPCs#1534
Merged
Remove dupe storage item if we get one back, to be compatible with Smoldot + legacy RPCs#1534
Conversation
…oldot + legacy RPCs
lexnv
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoldot returns the provided
start_keywhen fetching storage items (see smol-dot/smoldot#1692), whereas we don't expect this back from Substrate (it's badly named really;start_keydoes imply it will be handed back to me).In Subxt we remove such an entry if we find it when iterating over storage entries, to avoid duplicate entries being returned.
Closes #1453, closes #1525